Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build_project.sh with ROCr changes from ATD. #1195

Open
wants to merge 1 commit into
base: aomp-dev
Choose a base branch
from

Conversation

ampandey-AMD
Copy link
Contributor

No description provided.

@ampandey-AMD
Copy link
Contributor Author

ampandey-AMD commented Dec 17, 2024

ping @ronlieb

@ampandey-AMD
Copy link
Contributor Author

ampandey-AMD commented Dec 17, 2024

Hi Ron,

I don't know why we are patching rocr right now. patchrepo $ROCR_REPO_DIR fails currently and this is why build_project.sh is failing. I do have enabled it under env flag AOMP_APPLY_ATD_AMD_STAGING_PATCH.

@gregrodgers & @estewart08 do we need the current pr. Any comments from your side.
I thought that below patchrepo line should get deleted. Is that correct, @gregrodgers @ronlieb @estewart08 ?

# Check-openmp prep
# Patch rocr
ROCR_REPO_DIR=$AOMP_REPOS/$AOMP_ROCR_REPO_NAME
patchrepo $ROCR_REPO_DIR

@ampandey-AMD
Copy link
Contributor Author

ampandey-AMD commented Dec 17, 2024

Does that rocr repository corresponds to amd-staging branch or rocm release branch. From my experience by default **rocr-runtime** we have rocm-release branch in aomp-dev branch of aomp repository?

@ronlieb
Copy link
Contributor

ronlieb commented Dec 17, 2024

seems we need to patch rocr to add more libraries numa etc @gregrodgers would know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants