Add reject states for failing streamk params #1425
Open
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daineAMD
requested review from
jichangjichang,
KKyang,
aazz44ss,
vin-huang,
imcarsonliao,
hcman2,
Serge45,
Jinp800125,
TonyYHsieh and
solaslin
as code owners
|
Do we have any solutions in the existing logic yaml which will be rejected by this condition? If yes, we should remove them in the same change. |
jichangjichang
previously approved these changes
Dec 19, 2024
daineAMD
dismissed stale reviews from jichangjichang and AlexBrownAMD
via
2229174
After adding the last commit, I've checked and don't see any solutions which will be rejected by the condition. Will merge once CI passes. |
KKyang
approved these changes
Dec 21, 2024
jichangjichang
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.