Develop Stream VS config files generation from registry #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beanavil
requested review from
a team,
dgaliffiAMD and
MKKnorr
as code owners
|
@dgaliffiAMD @MKKnorr please assign any other relevant reviewer for VS-related changes, thanks! |
MKKnorr
reviewed
Dec 12, 2024
MKKnorr
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR essentially contains the modifications of the examples' VS config files after generating them from our internal registry.
The build errors observed in the pipeline are related to ROCm 6.2.0 and tackled in a different PR (#183) to keep the scope of the PRs as small as possible.