Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluding Readme.md to prevent being improperly rendered in the docs page #32

Conversation

prbasyal-amd
Copy link

PR Details

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • [* ] Documentation Update

Technical details

_Please explain the changes along with JIRA/Github link(if applies).: Excluded the Readme.md file being inaccurately rendered in the documentation portal resulting in broken links in the page.
https://rocm.docs.amd.com/projects/rocprofiler-sdk/en/latest/_doxygen/html/md__2home_2docs_2checkouts_2readthedocs_8org_2user__builds_2advanced-micro-devices-rocprofiler-sd40c0902389b09edf3210254f2740a88.html
image

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

  • Yes
  • [ *] No, Does not apply to this PR.

Updated CHANGELOG?

Needed for Release updates for a ROCm release.

  • Yes
  • No, Does not apply to this PR.

Added/Updated documentation?

  • Yes
  • No, Does not apply to this PR.

@prbasyal-amd prbasyal-amd added the documentation Improvements or additions to documentation label Nov 13, 2024
@bgopesh
Copy link
Contributor

bgopesh commented Nov 13, 2024

@prbasyal-amd -Please close this and create a PR against amd-staging for rocprofiler-sdk-internal.

1 similar comment
@bgopesh
Copy link
Contributor

bgopesh commented Nov 13, 2024

@prbasyal-amd -Please close this and create a PR against amd-staging for rocprofiler-sdk-internal.

@bgopesh bgopesh closed this Nov 13, 2024
ammarwa added a commit that referenced this pull request Dec 4, 2024
* Enabling Navi3 and Vega20 runners

* Update continuous_integration.yml

* Update continuous_integration.yml

* Fixing Github Actions issues

* Fixing docs workflow

* Fixing docs workflow miniconda3 location

* Fixing docs workflow env setup

* Fixing docs workflow env setup

* Fixing docs workflow miniconda3 env

* Fixing docs source build workflow

* Balancing between navi3, vega20, mi300, mi200

* git sync workflow update

* Adding Jira ticket place holder in PR Description

* Fixing RHEL & SLES Builds

* Fixing RHEL & SLES Builds

* Fixing RHEL & SLES Builds

* Fixing Re-run workflow

* Update pull_request_template.md

* Update continuous_integration.yml

---------

Co-authored-by: Ammar ELWazir <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants