Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all block pointers to tensor pointers #585

Merged
merged 5 commits into from
May 16, 2024

Conversation

vgokhale
Copy link
Collaborator

@vgokhale vgokhale commented May 10, 2024

Change all block pointers to tensor pointers

Block pointers are for nvidia TMAs. They are useful for regular loads as well but not well supported.

Also cleaned up some code I came across along the way and updated comment at the top.

@vgokhale vgokhale marked this pull request as ready for review May 16, 2024 19:12
@vgokhale vgokhale self-assigned this May 16, 2024
Copy link
Collaborator

@micmelesse micmelesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vgokhale vgokhale merged commit 440a2c3 into main_perf May 16, 2024
4 checks passed
@vgokhale vgokhale deleted the block_ptrs_to_tensor branch May 16, 2024 20:20
micmelesse pushed a commit that referenced this pull request Jun 14, 2024
Change all block pointers to tensor pointers

Block pointers are for nvidia TMAs. They are useful for regular loads as well but not well supported.

Also cleaned up some code I came across along the way and updated comment at the top.
micmelesse pushed a commit that referenced this pull request Jun 19, 2024
Change all block pointers to tensor pointers

Block pointers are for nvidia TMAs. They are useful for regular loads as well but not well supported.

Also cleaned up some code I came across along the way and updated comment at the top.
micmelesse pushed a commit that referenced this pull request Jul 16, 2024
Change all block pointers to tensor pointers

Block pointers are for nvidia TMAs. They are useful for regular loads as well but not well supported.

Also cleaned up some code I came across along the way and updated comment at the top.
micmelesse pushed a commit that referenced this pull request Jul 16, 2024
Change all block pointers to tensor pointers

Block pointers are for nvidia TMAs. They are useful for regular loads as well but not well supported.

Also cleaned up some code I came across along the way and updated comment at the top.
micmelesse pushed a commit that referenced this pull request Oct 28, 2024
Change all block pointers to tensor pointers

Block pointers are for nvidia TMAs. They are useful for regular loads as well but not well supported.

Also cleaned up some code I came across along the way and updated comment at the top.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants