Initial Account Security and Password Recovery, part of #41 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmsv-mx123
force-pushed
the
account_security
branch
from
3b924d0 to
ae1911d
Compare
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
reviewed
Dec 1, 2020
Hubcapp
requested changes
Dec 1, 2020
lmsv-mx123
force-pushed
the
account_security
branch
from
c63b49e to
c11ead7
Compare
…ble area since logout was buggy in tutorial island
|
LGTM thanks for all your work on this. |
lmsv-mx123
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaining work for #41 . Initially when sending over the question answers, it seems that in RSC127 it was sent encrypted "hashed" answer but was changed in later revisions to be just encrypted answers (including in RSC175). It was taken from the way of RSC175. Another good change was that when sending over the question in RSC127 it would have been for example "~:1" for the text of question 1, while later was changed to send out clientQuestion[1], probably to avoid dependency if one question was changed, then with old mechanism the user wouldn't know the answer for it