Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

186 open snapshot in editor #197

Merged
merged 3 commits into from
May 21, 2020

Conversation

gregveres
Copy link
Contributor

This PR does two things. It implements #186 and #191.
For #186, this creates a new button to load the snapshot in the editor so that you can quickly
see the snapshot - useful when writing tests.

I had created FR #191 because I wanted a way to generate the snapshots, not realizing that the
button was already there. This change makes the button visible all the time. The reason for that
is that there are times when you know the snapshots are out of date and need to be updated.
If you run the tests just to have them fail, it wastes time. Having this button visible all the time
saves time because you can generate the snapshots when you know they are out of date.

gregveres and others added 2 commits May 15, 2020 10:51
sync with official fork v1.7.0
This commit implements issue Raathigesh#186. I can't know if there is a snapshot
for each but I can add a button to the summary that opens the snapshot
for the file in the code editor. That's what this commit does. It adds
the button to the UI and a mutation to send to the server to open the
snapshot in the editor.
And it implements issue Raathigesh#191. There was already a button for generating
a snapshot, but it was only visible when there was a detected snapshot
error. This caused us to have to run known failing tests before we could
get the button to generate the snapshots. Now the button is there all
the time, so if you know your snapshots are out of date, then you can
generate them immediately and save time.
@Raathigesh
Copy link
Owner

If you could help with the merge conflict, I can get this merged as well and release a new version by this week.

@gregveres
Copy link
Contributor Author

@Raathigesh sorry, I don't know how those became merge conflicts and GitHub didn't suggest the proper merge for one of them. I have resolved the conflicts now with the code that should be there.

@Raathigesh Raathigesh merged commit f31897c into Raathigesh:master May 21, 2020
@Raathigesh
Copy link
Owner

Thanks for this as well. Looks good.

I'm planning to a sanity test this weekend and will do a release with all your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants