Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust 1.78.0 introduced some debug assertions for unsafe preconditions. One such precondition, which we have inadvertently violated for a while was that
slice::from_raw_parts
does not accept null pointers, even when the size is 0.An except from the Rust docs:
While another option could have been to replace
ptr
withNonNull::dangling
if it was null, simply handling this case separately seems like a simpler approach.This is the error that appeared when I tried running Hypermine in debug mode: