e2e: log to a file instead of stdout #1607
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raghavendra-talur
force-pushed
the
rtalur-e2e-log-file
branch
from
184d987 to
5aa7db1
Compare
nirs
reviewed
Oct 25, 2024
| @@ -23,12 +23,19 @@ func TestMain(m *testing.M) { | |||
|
|
|||
| flag.Parse() | |||
|
|
|||
| logFile, err := os.Create("ramentest.log") | |||
There was a problem hiding this comment.
"e2e.log"?
I'm not sure this should be the default. Logging to stdout is very easy to use and our log is not very large.
Maybe add --logfile option?
./run.sh -logfile e2e.logThere was a problem hiding this comment.
We can also always log to file regardless of stdout/stderr. This makes it easier to use the log after running other commands with lot of output.
If we always log to file, maybe we can use much less detailed log to stderr, maybe only the normal test output.
I also want to always keep drenv log in standard location to avoid the issue of not having logs to debug issues like this:
https://cloud-native.slack.com/archives/C043N6ZFV9S/p1732122420443799
Signed-off-by: Raghavendra Talur <[email protected]>
raghavendra-talur
force-pushed
the
rtalur-e2e-log-file
branch
from
5aa7db1 to
74c2a9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the test result output easier to read.