[WIP] Enhancements for DRClusterConfig

[raaizik]

Changes

• Adds CEL rule for ClusterID as it's a required and immutable field
• Adds basic status to record the phase and generation

Resolves issue #1636

[raghavendra-talur]

@raaizik This is where the discrepancy is. I am wondering why the make generate output is different for you and the CI.

Most likely a version difference in controller-gen.

[ShyamsundarR]

Looks good, some thoughts as below.

Can we add envtests around the following:

• Check status to ensure it reports the obGen and phase
• Add a replication schedule to change the generation of DRClusterConfig, and check if status reflects the latest obGen and Status
• Update the clusterID and expect a failure (due to the added CEL rule)

There is currently no way to test failed Phase (as that requires any one of the k8s APIs to fail, so we can leave that out)

I am thinking about Conditions instead of obGen and Phase, such that as we add S3 store reachability as well to the mix, it can be reported separately, like so:

  Conditions:
  - type: ConfigurationProcessed
    status: T|F
    reason: Processed|Failed
    message:
    obGen:
    transitionTime:
  - type: S3Reachable
    status: T|F
    reason: Reachable|Unreachable
    message:
    obGen:
    transitionTime:

Another reason would be that, phase can change for the same generation, if a new SC/VRC or any class is created on the cluster. To see when this changed we would also need to add a transitionTime to the status. These are covered in Conditions, and hence maybe easier to just use the same?