Dry up reading env vars #361
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I _think_ the only time it's safe to set these to nil is if BYPASS_OAUTH is set to true (i.e. when we're not logged in via Profile). In that case this `#destroy` method returns early so we can assume that they'll be set if we're logging out for real.
This is read in GithubWebhooksController and UploadJob. We use `ENV.fetch` to read it which implies that we're expecting it to exist so I think it's reasonable to add it to our .env files.
Nested under `x` in preparation for moving `GITHUB_WEBHOOK_REF` here too. As per the Rails docs[1]. [1]: https://guides.rubyonrails.org/configuring.html#custom-configuration
In preparation for reading for Rails config instead of ENV.
In preparation for reading from Rails config instead of ENV.
This will require developers to ensure they have this env var set in .env
This env var is set for review apps, staging and prod in Heroku. It will need to be set by devs in .env.
raspberrypiherokubot
temporarily deployed
to
editor-api-p-dry-up-rea-t9s2ih
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Points for consideration:
What's changed?
Description of what's been done - bullets are often best
Steps to perform after deploying to production
If the production environment requires any extra work after this PR has been deployed detail it here. This could be running a Rake task, a migration, or upgrading a Gem. That kind of thing.