Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #6556 by making the error more informative #6690

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

venom1204
Copy link
Contributor

In this i have made the error popping out to ber more informative by two things

  1. Which column(s) are missing.
  2. Which data.table is missing the column(s).

in this i have also modified the test examples in the /home/vinni/data.table/inst/tests
named
Test 1601.2, 1601.3, 1601.4
Test 1880.1 1880.2
Test 1962.016 1962.018, 1962.019, 1962.021
Test 2145.2
Test 2230.7

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.61%. Comparing base (3b2812b) to head (ee5ac99).

Files with missing lines Patch % Lines
R/merge.R 97.36% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6690      +/-   ##
==========================================
- Coverage   98.61%   98.61%   -0.01%     
==========================================
  Files          79       79              
  Lines       14559    14557       -2     
==========================================
- Hits        14358    14355       -3     
- Misses        201      202       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant