Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MIDI Delay X v0.3 > v0.4 #397

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Update MIDI Delay X v0.3 > v0.4 #397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions MIDI/talagan_MIDI Delay X.jsfx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
desc:MIDI Delay X
author: Ben 'Talagan' Babut
version: 0.3
version: 0.4
donation:
https://www.paypal.com/donate/?business=3YEZMY9D6U8NC&no_recurring=1&currency_code=EUR
license:
MIT (Do whatever you like with this code).
changelog:
- Initial release.
- [Bug/Behaviour Fix] Once an event programmation date is decided, do not make this trigger date subject to change by automation.
about:
# MIDI Delay X

Expand Down Expand Up @@ -107,13 +107,16 @@ function processEvents()
// - and an inverse factor when poping the events from the queue
//
// The reason might be to adapt to sample rate changes ? or dely/amount changes ?
// IMHO, for MIDI Delay X's purpose, we should not do this
// as automating the MIDI amount will modify the trigger time of events
// which is not what we want. Once an event date is decided, it's decided.


// Delay scaling, applied when poping
delay_sc = (delay_samples + samplesblock);
delay_sc = 1.0; // (delay_samples + samplesblock);

// Inverse delay scaling, applied when pushing
delay_isc = 1.0 / delay_sc;
delay_isc = 1.0; // 1.0 / delay_sc;

// process incoming events

Expand Down