Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fragment array functions in Simulation.jl are overwriting other helper functions #219

Open
mjohnson541 opened this issue Jun 11, 2023 · 2 comments
Open

Fragment array functions in Simulation.jl are overwriting other helper functions #219

mjohnson541 opened this issue Jun 11, 2023 · 2 comments

Comments

@mjohnson541
Copy link
Collaborator

Some of the new functions for handling fragment arrays weren't typed differently from other functions with the same name in Simulation.jl causing them to overwrite them. Currently this at least seems to prevent rop plotting in traditional mechanisms.
@hwpang
Copy link
Contributor

hwpang commented Jun 28, 2023

Thanks for catching this. I will work on this after I submitted my manuscript revision. I'm somewhat more occupied right now.

@mjohnson541 mjohnson541 mentioned this issue Jun 29, 2023
Open
@mjohnson541
Copy link
Collaborator Author

In the meantime I believe users can get around this issue by switching to commit baba92a.

@hwpang hwpang mentioned this issue Aug 8, 2023
Merged
@mjohnson541 mjohnson541 mentioned this issue Oct 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjohnson541 @hwpang