-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new domain, remove unused function, and fix rop function dispatch #230
Add new domain, remove unused function, and fix rop function dispatch #230
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
==========================================
- Coverage 49.65% 48.93% -0.73%
==========================================
Files 31 31
Lines 8146 8301 +155
==========================================
+ Hits 4045 4062 +17
- Misses 4101 4239 +138 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The simulation test is failing, but I've given comments on the changes.
30c985f
to
7819ee5
Compare
Change log:
|
c5be921
to
c86e172
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good. One quick question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1c580db
to
eb5202c
Compare
0cd6ac6
into
ReactionMechanismGenerator:main
ConstantTLiqFilmDomain
whose volume expands as the film grows. Its volume changes based on the mass of the film domain, where dV/dt = dm/dt / rho / (1 - epsilon) * epsilon, where rho is the density of the solid, and epsilon is the porosity of the film (vol frac of liquid in film)