generated from Real-Dev-Squad/website-template
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add task service for get task API #12
Open
samarpan1738
wants to merge
5
commits into
feat-get-todo-api-view-and-validator
Choose a base branch
from
feat-get-todo-api-view-and-service
base: feat-get-todo-api-view-and-validator
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add task service for get task API #12
samarpan1738
wants to merge
5
commits into
feat-get-todo-api-view-and-validator
from
feat-get-todo-api-view-and-service
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samarpan1738
changed the title
Add task service
Add task service implementing get tasks method
Dec 20, 2024
samarpan1738
changed the title
Add task service implementing get tasks method
Add task service for get task API
Dec 20, 2024
10 tasks
samarpan1738
force-pushed
the
feat-get-todo-api-view-and-validator
branch
from
December 22, 2024 19:38
074fa71
to
f91df5a
Compare
samarpan1738
force-pushed
the
feat-get-todo-api-view-and-service
branch
from
December 22, 2024 19:39
bf89c2a
to
81848f5
Compare
pankajjs
reviewed
Dec 25, 2024
Comment on lines
+10
to
+13
createdAt: datetime | None = None | ||
updatedAt: datetime | None = None | ||
createdBy: UserDTO | None = None | ||
updatedBy: UserDTO | None = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These values can ever be none?
pankajjs
reviewed
Dec 25, 2024
from todo.dto.task_dto import TaskDTO | ||
|
||
|
||
class GetTasksResponse(PaginatedResponse): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not TasksResponse
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 20 Dec 2024
Developer Name: Samarpan Harit
Important
THIS PR MUST BE MERGED AFTER
Issue Ticket Number
Description
SYSTEM
username. When we add authentication, we'll be using the correct use details hereSuccess Response
URL - GET http://127.0.0.1:8000/v1/tasks?page=1&limit=1Response Code: 200
Error Response (Incorrect query params)
URL - GET http://127.0.0.1:8000/v1/tasks?page=1&limit=-1Response Code: 400
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Success Response
Error Response (Incorrect query params)
Test Coverage
Coverage report
Additional Notes
The CI is failing right now because there an issue in the workflow. I have raised a PR to fix this. Once it's merged the CI should pass