new paginated functionality added in GET /tasks #647
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankushdharkar
requested changes
Aug 1, 2022
models/tasks.js
Outdated
| const tasksSnapshot = await tasksModel.get(); | ||
| const tasksSnapshot = await tasksModel | ||
| .orderBy("startedOn", "desc") | ||
| .startAfter(lastDoc ? lastDoc.startedOn : "") |
There was a problem hiding this comment.
If lastDoc is undefined (or null), does this call error out?
ankushdharkar
requested changes
Aug 5, 2022
| const fetchTasks = async (limit, offset) => { | ||
| let lastDoc; | ||
| if (offset) { | ||
| lastDoc = await tasksModel.doc(offset).get(); |
There was a problem hiding this comment.
Offset should be a number, but here, it seems to be used as a document_id.
| lastDoc = await tasksModel.doc(offset).get(); | ||
| lastDoc = lastDoc.data(); | ||
| } | ||
| const limitDocuments = Number(limit); |
There was a problem hiding this comment.
Can we request any number of documents from Firestore? Should there be an upper limit here?
|
Closing this, as this feature is already implemented (https://github.com/Real-Dev-Squad/website-backend/blob/develop/controllers/tasks.js) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests are yet to be created
API Contract