Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/one time user colors #735
base: develop
Are you sure you want to change the base?
Feature/one time user colors #735
Changes from 11 commits
2fed9ad
0f505b7
cd2c96d
5bd0f9a
5e4f75a
04c43e7
964dd56
0f65a11
146304a
01c8138
7a75444
54c94ce
f4d60d3
64f56cc
b210076
804c64c
b2c9c3c
b495022
807df54
2ecedb5
4b0df82
cc10b82
b8c7521
231cbef
48f6ef3
f322598
018f829
62fb581
542d504
7e0d00a
a522f0f
c723578
d76b090
c87fe9c
6aaafd7
c2151cd
0852243
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we creating an object to store color_id?
what else will we be storing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure ATM, we can make it just color_id, but if we are going to add more colors in the future then this would be better, should i change the property?