-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding missing Brick locations #260
base: dev/peterhart/wing
Are you sure you want to change the base?
Adding missing Brick locations #260
Conversation
Source/DTDLv2/RealEstateCore/Space/Architecture/Room/FoodHandling/Freezer.json
Show resolved
Hide resolved
Source/DTDLv2/RealEstateCore/Space/Architecture/Room/HospitalityBox.json
Outdated
Show resolved
Hide resolved
Source/DTDLv2/RealEstateCore/Space/Architecture/Room/SportsServiceRoom/HospitalityBox.json
Show resolved
Hide resolved
Source/DTDLv2/RealEstateCore/Space/Architecture/Room/TicketingBooth.json
Outdated
Show resolved
Hide resolved
Source/DTDLv2/RealEstateCore/Space/Architecture/Room/SportsServiceRoom/TicketingBooth.json
Show resolved
Hide resolved
Source/DTDLv2/RealEstateCore/Space/Architecture/Zone/FieldOfPlay.json
Outdated
Show resolved
Hide resolved
Source/DTDLv2/RealEstateCore/Space/Architecture/Zone/Gatehouse.json
Outdated
Show resolved
Hide resolved
@gtfierro thanks, appreciate the PR. Did a swift review, see comments above. In short it looks good. There's some small discrepancies. Great if you can fix? And then there're the questions if we shall create new subclasses for field of play and gate house as suggested. This is really more of a question to @hammar @cbupp @erikoskarwallin (can you guys add to the comments above if you feel we should resolve in another way than what I suggest / imply in comments). |
Thanks for the suggestions! I've made all of them and committed the changes. One related question -- are there textual definitions of these concepts available in DTDL? I've added them in the JSON documents above but I didn't see much of this in the existing classes. Do you have a preferred method for adding textual definition/descriptions? |
@PeteHart OK for me to create new subclasses for field of play and gate house as suggested. |
@PeteHart here are the deprecated Brick location classes that don't yet have a clear/specific counterpart in REC yet. Let me know if you agree with the placement/inclusion of them.
Related, please see the updates to our
brickpatches.ttl
file; I will update this to match these mappings once these are approved. We've also madebrick:isPartOf
a superproperty ofrec:isPartOf
because the former has fewer restrictions on it. For example REC'sisPartOf
restricts entities to only being part of a singular architectural entity; Brick'sisPartOf
does not have this restriction