Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing Brick locations #260

Open
wants to merge 2 commits into
base: dev/peterhart/wing
Choose a base branch
from

Conversation

gtfierro
Copy link
Contributor

@gtfierro gtfierro commented Mar 14, 2024

@PeteHart here are the deprecated Brick location classes that don't yet have a clear/specific counterpart in REC yet. Let me know if you agree with the placement/inclusion of them.

Related, please see the updates to our brickpatches.ttl file; I will update this to match these mappings once these are approved. We've also made brick:isPartOf a superproperty of rec:isPartOf because the former has fewer restrictions on it. For example REC's isPartOf restricts entities to only being part of a singular architectural entity; Brick's isPartOf does not have this restriction

@PeteHart
Copy link
Contributor

@gtfierro thanks, appreciate the PR. Did a swift review, see comments above. In short it looks good. There's some small discrepancies. Great if you can fix?

And then there're the questions if we shall create new subclasses for field of play and gate house as suggested. This is really more of a question to @hammar @cbupp @erikoskarwallin (can you guys add to the comments above if you feel we should resolve in another way than what I suggest / imply in comments).

@gtfierro
Copy link
Contributor Author

Thanks for the suggestions! I've made all of them and committed the changes.

One related question -- are there textual definitions of these concepts available in DTDL? I've added them in the JSON documents above but I didn't see much of this in the existing classes. Do you have a preferred method for adding textual definition/descriptions?

@erikoskarwallin
Copy link
Contributor

@PeteHart OK for me to create new subclasses for field of play and gate house as suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants