chore: Disable legacy upload #4160
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-horky
force-pushed
the
rhening-7569/disable-legacy
branch
3 times, most recently
from
45accfd to
759ef5f
Compare
|
Sorry for the abrupt comment before this PR being ready😅, but from the description of RHINENG-7569, the task is also trying to replace the API for BTW, it seems that the CCT-252 is more suitable to be linked to this PR. |
|
It's fine.
|
m-horky
force-pushed
the
rhening-7569/disable-legacy
branch
from
759ef5f to
c3a20a2
Compare
xiangce
added
the
client
|
Hi @m-horky - - Sorry for bringing this trouble to you, as we just resolved an urgent bug within the repo. Please rebase the master branch of your fork of insights-core and then rebase this branch again. Please reach out to me for any problems when doing the rebase. Apologize again. |
m-horky
force-pushed
the
rhening-7569/disable-legacy
branch
from
c3a20a2 to
d30e6d7
Compare
* Card ID: CCT-252 * Card ID: RHINENG-7569 This patch disables the legacy APIs. The code and configuration option will be removed later; this is the first step to get rid of the duplication and differences. Only the absolutely necessary changes were made to tests; without these removals the suite wouldn't pass. The rest will be cleaned up later. Signed-off-by: mhorky <[email protected]>
m-horky
force-pushed
the
rhening-7569/disable-legacy
branch
from
d30e6d7 to
b1f9ca4
Compare
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
This patch disables the legacy APIs. The code and configuration option will be removed later; this is the first step to get rid of the duplication and differences.
Only the absolutely necessary changes were made to tests; without these removals the suite wouldn't pass.