Fix/cct-375: Change location of /tmp/insights-client.ppid #4269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change was made in fle `insights/client/constants.py [row 83]` where the orginal file path `/tmp/insights-client.pidd` was changed to `/tmp/run/insights-client.pidd`. Motivation for the change was to place `insights-client.pid` file to directory owned by insights-client. CARD: CCT-375 Signed-off-by: Martin Grunwald <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4269 +/- ##
=========================================
Coverage 77.18% 77.19%
=========================================
Files 762 762
Lines 41512 41485 -27
Branches 8773 6603 -2170
=========================================
- Hits 32041 32023 -18
+ Misses 8413 8399 -14
- Partials 1058 1063 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
m-horky
approved these changes
Nov 20, 2024
zpetrace
approved these changes
Nov 28, 2024
|
Thanks @zpetrace. I'll get one more sanity review from SELinux team before we merge this. |
|
Can one of the admins verify this patch? |
xiangce
added
the
client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change was made in fle
insights/client/constants.py [row 83]where the orginal file path
/tmp/insights-client.piddwas changedto
/tmp/run/insights-client.pidd.Motivation for the change was to place
insights-client.pidfileto directory owned by
insights-client.CARD: CCT-375