Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin flask_caching to <=2.0.2 #380

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

r14chandra
Copy link
Contributor

@r14chandra r14chandra commented Oct 4, 2023

AttributeError: 'RedisCache' object has no attribute '_client'
The above is caused by flask_caching v1.11.1 and is fixed in v2.0.0.
To upgrade it to the latest one we need to pin flask <v3.0.0 as its latest version (2.0.2) depends on Flask (<3).
And in turn, we would need to pin werkzeug <v3.0.0

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@r14chandra r14chandra force-pushed the poetry-cache branch 2 times, most recently from 6ad7f6c to 25427db Compare October 4, 2023 11:47
@r14chandra r14chandra force-pushed the poetry-cache branch 2 times, most recently from 8de8355 to 591de43 Compare October 4, 2023 20:52
@r14chandra r14chandra changed the title clear pypi cache before installing packages handle compatibility among flask, flask_caching and werkzeug packages Oct 4, 2023
@upadhyeammit
Copy link
Contributor

@r14chandra my thoughts on this,

TL;DR: I think these extra pipelines are there as indicator for us to know if we can update to newer version of dependencies without breaking anything and without major change. If we pin the versions in that then it would not give us that benefit?

We have the extra pipelines to exactly do what you are doing however it is to help in bumping versions in the pyproject file, I mean in production.

If we go by this road, I mean pinning the versions for extra gh pipes then we would also need to keep updating them once we get newer versions of dependencies, and if we miss on this then it would actually defeat the benefit of extra gh action? I mean, now as you have pinned the versions we don't know if its breaking for next upcoming version as well?

If we dont go by this road, no pinning at all. We would always know its failing for the latest ones and that means,

  1. Our app is not outright ready for consuming the latest packages
  2. We would need to see the version dependencies and pin the stuff if we want to get it working for latest ones

@r14chandra r14chandra changed the title handle compatibility among flask, flask_caching and werkzeug packages Pin flask_caching to <=2.0.2 Oct 5, 2023
@r14chandra r14chandra merged commit b6c7c74 into RedHatInsights:main Oct 5, 2023
4 of 5 checks passed
@r14chandra r14chandra deleted the poetry-cache branch October 11, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants