Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get source pkg from installed nevra for unfixed cves #88

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

psegedy
Copy link
Member

@psegedy psegedy commented Dec 2, 2024

we need to get source package from installed nevra not just from installed package name.
We are showing false positive unfixed cves for packages built from different sources. E.g. bpftool is built from kernel and kernel-rt source packages and we are showing the CVE reported for kernel-rt when regular kernel is used which is incorrect (CVE-2022-0516 for bpftool-0:4.18.0-553.30.1.el8_10.x86_64)

Copy link

jira-linking bot commented Dec 2, 2024

Commits missing Jira IDs:
dedafda
262f62d
Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-14565

@psegedy psegedy requested a review from jdobes December 2, 2024 17:31
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 59.25926% with 11 lines in your changes missing coverage. Please review.

Project coverage is 60.54%. Comparing base (86f6b90) to head (262f62d).
Report is 85 commits behind head on main.

Files with missing lines Patch % Lines
vmaas/vulnerabilities.go 59.25% 9 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   56.74%   60.54%   +3.80%     
==========================================
  Files          11       15       +4     
  Lines        2062     2281     +219     
==========================================
+ Hits         1170     1381     +211     
+ Misses        838      817      -21     
- Partials       54       83      +29     
Flag Coverage Δ
unittests 60.54% <59.25%> (+3.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdobes jdobes merged commit 7404e32 into RedHatInsights:main Dec 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants