Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rewrite vmaas repos endpoint in go #92

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Dugowitch
Copy link
Contributor

This PR should wait until #90 gets merged

Copy link

jira-linking bot commented Dec 19, 2024

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-13556

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 79.28571% with 29 lines in your changes missing coverage. Please review.

Project coverage is 61.66%. Comparing base (86f6b90) to head (b17a2c6).
Report is 93 commits behind head on main.

Files with missing lines Patch % Lines
vmaas/repos.go 65.82% 23 Missing and 4 partials ⚠️
vmaas/vmaas.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   56.74%   61.66%   +4.92%     
==========================================
  Files          11       17       +6     
  Lines        2062     2418     +356     
==========================================
+ Hits         1170     1491     +321     
- Misses        838      841       +3     
- Partials       54       86      +32     
Flag Coverage Δ
unittests 61.66% <79.28%> (+4.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants