Fix incorrect type annotations #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike8699
added a commit
to phst-randomizer/ph-randomizer
that referenced
this pull request
Sep 29, 2024
Temporary measure until RoadrunnerWMC/ndspy#22 is merged.
mike8699
added a commit
to phst-randomizer/ph-randomizer
that referenced
this pull request
Dec 28, 2024
Temporary measure until RoadrunnerWMC/ndspy#22 is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems some of the type annotations I added in #16 and #18 were incorrect. I discovered this after upgrading my project to use ndspy 4.2.0, and it started failing type checking (PR, failed mypy CI run).
I confirmed the
decompressreturn type isbytearrayby calling it on a compressed ARM9bytesobject and callingtype()on it. The type ofOverlay.datais easily confirmed as abytearrayby looking at the__init__constructor for that class.