Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce insert_range for the Treemap #240

Merged
merged 6 commits into from
Sep 1, 2022
Merged

Introduce insert_range for the Treemap #240

merged 6 commits into from
Sep 1, 2022

Conversation

Kerollmops
Copy link
Member

@Kerollmops Kerollmops commented Sep 1, 2022 •
edited
Loading

This is a follow-up of #222, I cleaned it up before merging it into the main branch.

Closes #198

irevoire
irevoire approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

src/treemap/inherent.rs Outdated Show resolved Hide resolved
Kerollmops
Kerollmops commented Sep 1, 2022
View reviewed changes
Copy link
Member Author

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @irevoire!
bors merge

@bors
Copy link
Contributor

bors bot commented Sep 1, 2022

Build succeeded:

@bors bors bot merged commit 7f5627b into main Sep 1, 2022
@bors bors bot deleted the tmp-insert-range branch September 1, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irevoire irevoire irevoire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RoaringTreemap has no insert_range method
3 participants
@Kerollmops @irevoire @not-jan