Add support for deregister entity #38
Conversation
sjudd
force-pushed
the
sam/10-31-Add_support_for_deregister_service
branch
from
15b8a87 to
edc6ac5
Compare
|
I've promoted this to a full PR early because it looks like I can't run the CI checks without someone taking a look. Hope that's ok. |
|
Hi @sjudd Thank you for the contribution! Would you mind signing the CLA? :) |
|
Hi @kushudai I would almost certainly be happy to, but I don't know how? I don't see a link to the CLA or where to sign it? |
Ah, apologies, It could definitely be clearer. The way to sign it is merely to a leave a comment on the PR like so: #32 (comment) |
|
I have read the CLA Document and I hereby sign the CLA |
|
Hi @kushudai, let me know if there's anything else i can do here. Thanks for taking a look! |
Hi apologies for the delay. I don't quite understand why the CLA check is failing. I'm trying to get help internally for this. |
|
Thank you, I really appreciate it. I get these things can be a pain :/ |
Hi @sjudd I merged #39 and we updated some other secrets which had expired. Together this should resolve this issue. Could you merge master to this fork branch? Huge thanks to @rgychiu for diagnosing and fixing the problems here! |
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
What problem are we solving?
Deregister entity is not supported by this library, but it is by Consul's API: https://www.consul.io/api-docs/catalog#deregister-entity
How are we solving the problem?
Adding support :)
Checks
Please check these off before promoting the pull request to non-draft status.