-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop the robots when the stop receiving packages for 1 sec #168
Conversation
@mahi97 I tested it with a match test and I think this pull request is ready for review now. One question, should I change something on the piece of code complained bu the CodeFactor? |
@g3force this pull request is open for quite some time now... do I need to change anything before the pull request is merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me except for the comments.
@g3force what about now? |
And please fix the CodeFactor issue. One method you modified is too complex now. Move code into a new method. |
Identify the Bug
Closes #166
Description of the Change
blueControlSocket
, theQElapsedTimer
elapsedLastPackageBlue
is restarted.MainWindow::update
will check every time it is called ifelapsedLastPackageBlue
has not been restarted for more than one second. If the condition is true, it will stop all blue robot. A similar/equivalent approach was made for theyellowControlSocket
.Alternate Designs
Nothing.
Possible Drawbacks
Verification Process
Release Notes
Stop the robots when the stop receiving packages for 1 second