-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement RAC Style Library into Aurora #683
Open
HaSistrunk
wants to merge
110
commits into
development
Choose a base branch
from
issue-667
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaSistrunk
temporarily deployed
to
development
September 20, 2024 17:03 — with
GitHub Actions
Inactive
HaSistrunk
had a problem deploying
to
development
September 23, 2024 13:08 — with
GitHub Actions
Failure
HaSistrunk
temporarily deployed
to
development
September 24, 2024 16:56 — with
GitHub Actions
Inactive
…otals from titles
HaSistrunk
temporarily deployed
to
development
September 24, 2024 19:24 — with
GitHub Actions
Inactive
HaSistrunk
temporarily deployed
to
development
September 26, 2024 15:40 — with
GitHub Actions
Inactive
HaSistrunk
had a problem deploying
to
development
November 25, 2024 21:56 — with
GitHub Actions
Failure
HaSistrunk
temporarily deployed
to
development
November 26, 2024 17:12 — with
GitHub Actions
Inactive
HaSistrunk
force-pushed
the
issue-667
branch
from
November 26, 2024 17:21
ce87316
to
7ba6c78
Compare
HaSistrunk
had a problem deploying
to
development
November 26, 2024 17:21 — with
GitHub Actions
Failure
HaSistrunk
temporarily deployed
to
development
November 26, 2024 17:29 — with
GitHub Actions
Inactive
HaSistrunk
temporarily deployed
to
development
November 26, 2024 19:44 — with
GitHub Actions
Inactive
HaSistrunk
temporarily deployed
to
development
November 26, 2024 20:10 — with
GitHub Actions
Inactive
HaSistrunk
temporarily deployed
to
development
November 26, 2024 20:17 — with
GitHub Actions
Inactive
HaSistrunk
temporarily deployed
to
development
November 26, 2024 21:06 — with
GitHub Actions
Inactive
HaSistrunk
temporarily deployed
to
development
December 13, 2024 20:39 — with
GitHub Actions
Inactive
HaSistrunk
temporarily deployed
to
development
December 19, 2024 15:28 — with
GitHub Actions
Inactive
HaSistrunk
temporarily deployed
to
development
December 19, 2024 18:10 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #555
fix #658
fix #646
fix #664
fix #668
Implements the RAC Style Library into Aurora including substantial UI redesign and app updates.
machine_file_upload_time
data is already defined via models and views in the format we display it in, so unless I'm missing something we don't need to define a date format in the templates).delete_object_js
script for Bagit and Rights org tables so that "there are no existing..." paragraph appears when table is deleted.Style Library updates
See styles repo PR 235 for associated updates made to style library based on its implementation in Aurora.
Other considerations
We have implemented Datatables serverside in Aurora. If we anticipate 1000s of rows of data (which we may, over time!) this makes sense. Otherwise, I'm not sure we need that and it could make maintaining local Datatables functionality easier to use a client side implementation. I haven't changed the implementation here, though. Could be worth revisiting as part of issue #646 .