Fixed Contribution Graph image URL #55
Conversation
|
@chinma-yyy thanks for the contribution and pointing this out. But this makes the project dependent on another project which may go down any moment leaving us with a buggy interface. What do you think @henit-chobisa ? |
Yes , @samad-yar-khan this was the original issue. Already in this File we were retrieving the graph from another project before but as it has been moved to another platform this issue was raised.Thank You. |
|
@henit-chobisa Since you introduced this, would like your opinion on it. |
Also to Note: Most probably changing deployment from heroku to cyclic would due to the heroku made thier service completely paid. |
|
@chinma-yyy @Nabhag8848 Tested the PR. I believe the project that we are using to render this is well maintained. If the URL changes in the future, some contributor will sure open and issue or we can host ourselves. |
| export function githubActivityGraphUrl(username : string): string { | ||
| return `https://activity-graph.herokuapp.com/graph?username=${username}&bg_color=ffffff&color=708090&line=24292e&point=24292e` | ||
| return `https://github-readme-activity-graph.cyclic.app/graph?username=${username}&bg_color=ffffff&color=708090&line=24292e&point=24292e&area=true&hide_border=true` | ||
| } |
There was a problem hiding this comment.
@chinma-yyy Can you please add a comment, linking the project that we are using for this so this remains documented incase they change the URL ?
| export function githubActivityGraphUrl(username : string): string { | ||
| return `https://activity-graph.herokuapp.com/graph?username=${username}&bg_color=ffffff&color=708090&line=24292e&point=24292e` | ||
| return `https://github-readme-activity-graph.cyclic.app/graph?username=${username}&bg_color=ffffff&color=708090&line=24292e&point=24292e&area=true&hide_border=true` | ||
| } |
There was a problem hiding this comment.
@chinma-yyy can we do something like this to make the params more readable or I am sure you can come with a neater way which can append the params. Would improve readability.
let base_url = new URL("https://github-readme-activity-graph.cyclic.app/graph");
base_url.searchParams.append('user_name',username);
base_url.searchParams.append('bg_color','ffffff');
base_url.searchParams.append('color','708090');
base_url.searchParams.append('line','24292e');
base_url.searchParams.append('area','true');
base_url.searchParams.append('hide_border','true');
base_url.searchParams.append('&point','24292e');
return base_url.toString()
|
@samad-yar-khan The pr ready |
yep, @samad-yar-khan I believe we shouldn't host ourselves, Here is one Cons and Pros which i think we should note if we want to host ourselves: Cons of Self-Hosting
Pros of Self-Hosting
I see there are more Cons than Pros if we self-host also there would be more work around, We should avoid it if we can. cc @chinma-yyy |
Issue(s)
Closes #53
Acceptance Criteria fulfillment
Proposed changes (including videos or screenshots)
Before
After