Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add announcement , display room avatar , make room name clickable. #734

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Feat: add announcement , display room avatar , make room name clickable. #734

wants to merge 8 commits into from
+193 −43

Conversation

abirc8010
Copy link
Contributor

@abirc8010 abirc8010 commented Dec 25, 2024 •
edited
Loading

Brief Title

Acceptance Criteria fulfillment

  • Display the room avatar alongside the room name.
  • Display room information when the room name is clicked.
  • Display the room announcement as in Rocket.Chat, and for large announcements, show them in a modal.
  • Add a showAnnouncement prop that can be passed to embeddedChat to hide the announcement if required

Fixes #733

Video/Screenshots

Screencast.from.2024-12-25.23-09-43.webm

For dark theme:

image

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-734 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@abirc8010
Copy link
Contributor Author

Hey @Spiral-Memory will this background be ok for dark theme in announcement ?

@Spiral-Memory
Copy link
Collaborator

Things are looking good, just add some padding in the modal.. give it some more height..

N then I'll approve and test and let you know my further comments.

@abirc8010
Copy link
Contributor Author

image

@Spiral-Memory I have added padding to modal and increased it's height

Spiral-Memory
Spiral-Memory reviewed Dec 25, 2024
View reviewed changes
packages/react/src/views/ChatBody/ChatBody.js Outdated
css={[
styles.announcementTextBox,
css`
text-decoration: ${isOverflowing ? 'underline' : 'none'};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why adding a underline when overflowing ? Specific reason ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to give a hint to user that the announcement is clickable , but I just realized that in RC the underline appears only if the user hovers over the announcement , should I consider removing it in normal view?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaa better remove it, keep it on hover only

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the text underline in normal view

@abirc8010
Copy link
Contributor Author

Hey @Spiral-Memory could you please create a sample announcement for the pr preview for testing purposes ?

@abirc8010 abirc8010 mentioned this pull request Dec 29, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spiral-Memory Spiral-Memory Spiral-Memory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: display room announcement , room avatar and make room name clickable
2 participants
@abirc8010 @Spiral-Memory