Feat: add announcement , display room avatar , make room name clickable. #734
Conversation
|
Hey @Spiral-Memory will this background be ok for dark theme in announcement ? |
|
Things are looking good, just add some padding in the modal.. give it some more height.. N then I'll approve and test and let you know my further comments. |
|
@Spiral-Memory I have added padding to modal and increased it's height |
| css={[ | ||
| styles.announcementTextBox, | ||
| css` | ||
| text-decoration: ${isOverflowing ? 'underline' : 'none'}; |
There was a problem hiding this comment.
Why adding a underline when overflowing ? Specific reason ?
There was a problem hiding this comment.
Just to give a hint to user that the announcement is clickable , but I just realized that in RC the underline appears only if the user hovers over the announcement , should I consider removing it in normal view?
There was a problem hiding this comment.
Yaa better remove it, keep it on hover only
There was a problem hiding this comment.
I removed the text underline in normal view
|
Hey @Spiral-Memory could you please create a sample announcement for the pr preview for testing purposes ? |
I don't think i have the permission to do that.. |
…le. (RocketChat#734) * Added room announcement feature , display avatar and make room name clickable * remove showChannelAvatar from ECOptions * Add padding * Add padding to modal * Remove text underline in announcement in normal view * add showAnnouncement dependency to useEffect * Run prettier * replace channelInfo.description
Brief Title
Acceptance Criteria fulfillment
Fixes #733
Video/Screenshots
Screencast.from.2024-12-25.23-09-43.webm
For dark theme:
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-734 after approval. Contributors are requested to replace
<pr_number>with the actual PR number.