Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Hidden the copy option for audio and video messages #714

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

dhairyashiil
Copy link
Contributor

@dhairyashiil dhairyashiil commented Dec 22, 2024

Brief Title

Hidden the copy option for audio and video messages

Acceptance Criteria fulfillment

  • Hidden the copy option for audio and video messages.

Fixes #713

Video/Screenshots

Hidden.the.copy.option.mp4

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-714 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@dhairyashiil dhairyashiil changed the title BUG: Hide copy option for audio and video messages BUG: Hidden the copy option for audio and video messages Dec 22, 2024
@dhairyashiil dhairyashiil changed the title BUG: Hidden the copy option for audio and video messages Fix: Hidden the copy option for audio and video messages Dec 25, 2024
@Spiral-Memory
Copy link
Collaborator

Instead of hiding, we can copy file name of it just like in RC
Follow the similar pattern

Thanks

@dhairyashiil
Copy link
Contributor Author

Instead of hiding, we can copy file name of it just like in RC Follow the similar pattern

Thanks

Yupp, Thanks. Working on it

@dhairyashiil
Copy link
Contributor Author

Hello @Spiral-Memory,
The expected pattern, which is "Instead of hiding the icon, we can copy the filename just like in RC," has been resolved by PR #716. So, maybe we can close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Hide 'Copy' option for Audio and Video Messages
2 participants