Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Removed extra top space for audio and video messages to improve UI consistency #728

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

dhairyashiil
Copy link
Contributor

@dhairyashiil dhairyashiil commented Dec 24, 2024

Brief Title

Removed Extra Space Above Audio and Video Messages

Acceptance Criteria fulfillment

  • Remove the unnecessary space above audio and video messages to make the UI consistent with text and file messages.
  • Verify that the change does not introduce any issues with other message types or UI elements.

Fixes #727
Fixes #768

Video/Screenshots

without.space.audio.and.video.messages.mp4

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-728 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@devanshkansagra
Copy link
Contributor

Hey @dhairyashiil, can you do one thing? just quote an audio or video message and show me the ui look.

@dhairyashiil
Copy link
Contributor Author

Hey @dhairyashiil, can you do one thing? just quote an audio or video message and show me the ui look.

Hello Devansh (@devanshkansagra), when I tried to quote an audio or video message, I noticed that there was no space present, and the UI didn't look good.

I have fixed it now. Thank you for pointing it out.

I have attached the latest screenshots that were taken after the recent commit.

image

and

image

@dhairyashiil dhairyashiil changed the title BUG: Removed extra top space for audio and video messages to improve UI consistency Fix: Removed extra top space for audio and video messages to improve UI consistency Dec 25, 2024
@Spiral-Memory
Copy link
Collaborator

Pls resolve conflicts

@dhairyashiil
Copy link
Contributor Author

After the recently merged PRs,

The download ActionButton was not looking consistent with UI, I fixed it as well.

Before fixing it:
image

After fixing it:
image

@dhairyashiil
Copy link
Contributor Author

Pls resolve conflicts

The conflicts have been resolved. Please review the changes.
Thank you

@devanshkansagra
Copy link
Contributor

Hay @dhairyashiil, have you tested it with other ui like curved variants?

@dhairyashiil
Copy link
Contributor Author

dhairyashiil commented Jan 2, 2025

Hay @dhairyashiil, have you tested it with other ui like curved variants?

Hello Devansh, I didn’t check that yesterday, but yes, for the curved variants, it looks consistent.

I just checked the case when a description is present for audio and video messages, and I noticed the download button wasn’t inline. I’ve handled this case and added conditional CSS:
image

Now the UI looks even more consistent.

@dhairyashiil
Copy link
Contributor Author

Curved Variant (Aqua Breeze):

margin.for.download.button.according.to.description.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants