-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Removed extra top space for audio and video messages to improve UI consistency #728
base: develop
Are you sure you want to change the base?
Fix: Removed extra top space for audio and video messages to improve UI consistency #728
Conversation
Hey @dhairyashiil, can you do one thing? just quote an audio or video message and show me the ui look. |
Hello Devansh (@devanshkansagra), when I tried to quote an audio or video message, I noticed that there was no space present, and the UI didn't look good. I have fixed it now. Thank you for pointing it out. I have attached the latest screenshots that were taken after the recent commit. and |
Pls resolve conflicts |
The conflicts have been resolved. Please review the changes. |
Hay @dhairyashiil, have you tested it with other ui like curved variants? |
Hello Devansh, I didn’t check that yesterday, but yes, for the curved variants, it looks consistent. I just checked the case when a description is present for audio and video messages, and I noticed the download button wasn’t inline. I’ve handled this case and added conditional CSS: Now the UI looks even more consistent. |
Curved Variant (Aqua Breeze): margin.for.download.button.according.to.description.mp4 |
Brief Title
Removed Extra Space Above Audio and Video Messages
Acceptance Criteria fulfillment
Fixes #727
Fixes #768
Video/Screenshots
without.space.audio.and.video.messages.mp4
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-728 after approval. Contributors are requested to replace
<pr_number>
with the actual PR number.