Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Added User Roles Type Filtering for Admins & Displayed User Roles Next to Member Info (Admin View) #743

Conversation

dhairyashiil
Copy link
Contributor

@dhairyashiil dhairyashiil commented Dec 27, 2024

Brief Title

User Roles Type Filtering for Admins

Acceptance Criteria fulfillment

  • Added a dropdown filter to select specific user roles (Admin, Leader, Moderator, Owner)
  • Implemented dynamic filtering logic to show only selected user roles.
  • Default state of the filter is set to "All", displaying all user roles until a specific filter is selected.
  • Displayed the corresponding user role next to the member info in the members' list UI, for each role except for the only user role.

Fixes #742

Video/Screenshots

User.role.filter.and.display.tag.mp4

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-743 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@dhairyashiil dhairyashiil changed the title Feat: Added User Roles Type Filtering for Admins Feat: Added User Roles Type Filtering for Admins & Displayed User Roles Next to Member Info (Admin View) Dec 27, 2024
@dhairyashiil
Copy link
Contributor Author

Screenshots:

image

image

image

image

@abirc8010
Copy link
Contributor

Hey @dhairyashiil, a user can have multiple roles, right ? So, can we consider applying the filter based on multiple roles ?

@dhairyashiil
Copy link
Contributor Author

Hey @dhairyashiil, a user can have multiple roles, right ? So, can we consider applying the filter based on multiple roles ?

Hello Abir, I missed that. I will update the logic from select to multi-select. Thank you.

@dhairyashiil
Copy link
Contributor Author

Added the Multi-Select functionality.

Video:

multiselect.mp4

@Spiral-Memory
Copy link
Collaborator

Hey @dhairyashiil,

I don’t think this is necessary. It would be better to confirm before raising such issues, as I want to ensure no one’s efforts go to waste.

We aim to ensure that the changes align with the objectives of EmbeddedChat.

I am closing this for now, maybe we can reopen if we feel its necessary.
Thanks @dhairyashiil

@dhairyashiil
Copy link
Contributor Author

Hey @dhairyashiil,

I don’t think this is necessary. It would be better to confirm before raising such issues, as I want to ensure no one’s efforts go to waste.

We aim to ensure that the changes align with the objectives of EmbeddedChat.

I am closing this for now, maybe we can reopen if we feel its necessary. Thanks @dhairyashiil

Yes, Thanks for the feedback! I'll confirm first next time. We can revisit if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants