-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct delete messages permission behavior in Administration #752
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pls resolve conflicts |
…e permission issues for viewing full user info (RocketChat#756)
* updated handleEditMessage functionality, added valdation for audio, video and file message * I have hidden the edit option for the audio/video message, and reverted previous approach of showing popup message * fix: apply Prettier formatting * Update visibility logic for 'Edit' button * wrapped logic in the variable 'isVisibleForMessageType' for this check and used it
…ketChat#654) * pin * removed comment
…le. (RocketChat#734) * Added room announcement feature , display avatar and make room name clickable * remove showChannelAvatar from ECOptions * Add padding * Add padding to modal * Remove text underline in announcement in normal view * add showAnnouncement dependency to useEffect * Run prettier * replace channelInfo.description
* fix: user action messages * remove showUsername
RocketChat#706) * feat: add password visibility toggle feature in API development portal * Simplify changes --------- Co-authored-by: Zishan Ahmad <[email protected]>
* feat: insert links in chat * fix lint --------- Co-authored-by: Zishan Ahmad <[email protected]>
…#677) * Fix the issue of mentioning the user in the file description * Removed all unwanted warnings * Formatted with prettier * Adjusted the width of the mentions preview in the file description * fixed the position of mentions preview such that it does not affect the height of file upload modal * Fixed all the inconsistencies * Fixed minor design inconsistency --------- Co-authored-by: Zishan Ahmad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Title
Resolve Delete permission behaviour in Administration
Acceptance Criteria fulfillment
Ensure normal users cannot see the delete icon when
deleteOwnMessage
is set to false by adminAlign permission behaviour with the hierarchy:
1.
forcedeletemessage
2.
deletemessage
3.
deleteOwnMessage
Fix visibility inconsistencies in delete icon functionality.
Fixes #749
Video/Screenshots
Permissions.-.Singha.-.Brave.2024-12-29.13-48-15.mp4
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-752 after approval. Contributors are requested to replace
<pr_number>
with the actual PR number.