Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct delete messages permission behavior in Administration #752

Closed

Conversation

SinghaAnirban005
Copy link
Contributor

@SinghaAnirban005 SinghaAnirban005 commented Dec 29, 2024

Brief Title

Resolve Delete permission behaviour in Administration

Acceptance Criteria fulfillment

  • Ensure normal users cannot see the delete icon when deleteOwnMessage is set to false by admin

  • Align permission behaviour with the hierarchy:
    1. forcedeletemessage
    2. deletemessage
    3. deleteOwnMessage

  • Fix visibility inconsistencies in delete icon functionality.

Fixes #749

Video/Screenshots

Permissions.-.Singha.-.Brave.2024-12-29.13-48-15.mp4

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-752 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@Spiral-Memory
Copy link
Collaborator

Pls resolve conflicts

SinghaAnirban005 and others added 11 commits January 1, 2025 23:39
* updated handleEditMessage functionality, added valdation for audio, video and file message

* I have hidden the edit option for the audio/video message, and reverted previous approach of showing popup message

* fix: apply Prettier formatting

* Update visibility logic for 'Edit' button

* wrapped logic in the variable 'isVisibleForMessageType' for this check and used it
…le. (RocketChat#734)

* Added room announcement feature , display avatar and make room name clickable

* remove showChannelAvatar from ECOptions

* Add padding

* Add padding to modal

* Remove text underline in announcement in normal view

* add showAnnouncement dependency to useEffect

* Run prettier

* replace channelInfo.description
* fix: user action messages

* remove showUsername
RocketChat#706)

* feat: add password visibility toggle feature in API development portal

* Simplify changes

---------

Co-authored-by: Zishan Ahmad <[email protected]>
* feat: insert links in chat

* fix lint

---------

Co-authored-by: Zishan Ahmad <[email protected]>
…#677)

* Fix the issue of mentioning the user in the file description

* Removed all unwanted warnings

* Formatted with prettier

* Adjusted the width of the mentions preview in the file description

* fixed the position of mentions preview such that it does not affect the height of file upload modal

* Fixed all the inconsistencies

* Fixed minor design inconsistency

---------

Co-authored-by: Zishan Ahmad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Incorrect Behaviour for delete Permission in Administration Settings
7 participants