Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Return departmentsAllowedToForward property in livechat/config endpoint #33060

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from

Conversation

matheusbsilva137
Copy link
Member

@matheusbsilva137 matheusbsilva137 commented Aug 14, 2024

Proposed changes (including videos or screenshots)

  • Add departmentsAllowedToForward property to departments returned by the livechat/config endpoint (this is a requirement for a client improvement described in CORE-410)

Issue(s)

Steps to test or reproduce

Further comments

CORE-652

Copy link
Contributor

dionisio-bot bot commented Aug 14, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.3.0, but it targets 7.2.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 14, 2024

🦋 Changeset detected

Latest commit: 9d77d84

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/livechat Minor
@rocket.chat/model-typings Minor
@rocket.chat/apps Patch
@rocket.chat/models Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
rocketchat-services Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/instance-status Patch
@rocket.chat/presence Patch
@rocket.chat/network-broker Patch
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/ui-contexts Major
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.24%. Comparing base (d37433b) to head (9d77d84).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33060      +/-   ##
===========================================
+ Coverage    59.28%   60.24%   +0.95%     
===========================================
  Files         2820     2684     -136     
  Lines        67903    66225    -1678     
  Branches     15094    14653     -441     
===========================================
- Hits         40254    39894     -360     
+ Misses       24827    23531    -1296     
+ Partials      2822     2800      -22     
Flag Coverage Δ
unit 75.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@matheusbsilva137 matheusbsilva137 marked this pull request as ready for review August 23, 2024 22:02
@matheusbsilva137 matheusbsilva137 requested review from a team as code owners August 23, 2024 22:02
@matheusbsilva137 matheusbsilva137 marked this pull request as draft August 28, 2024 15:01
@matheusbsilva137 matheusbsilva137 marked this pull request as ready for review August 28, 2024 15:02
MarcosSpessatto
MarcosSpessatto previously approved these changes Sep 2, 2024
@MarcosSpessatto MarcosSpessatto added this to the 6.13 milestone Sep 2, 2024
@scuciatto scuciatto removed this from the 6.13 milestone Sep 16, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33060/
on branch gh-pages at 2024-12-23 20:58 UTC

Copy link
Contributor

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add some UI e2e tests? I know we didn't change any client files, but there are some behavior changes on the UI, I think we can add one to this file https://github.com/RocketChat/Rocket.Chat/blob/develop/apps/meteor/tests/e2e/omnichannel/omnichannel-livechat-department.spec.ts or even a livechat API test to check if the widget api is respecting the fowarding limits implemented here

@tapiarafael
Copy link
Member

Is it possible to add some UI e2e tests? I know we didn't change any client files, but there are some behavior changes on the UI, I think we can add one to this file develop/apps/meteor/tests/e2e/omnichannel/omnichannel-livechat-department.spec.ts or even a livechat API test to check if the widget api is respecting the fowarding limits implemented here

I was looking at the code/task, and I don't think that there are any changes in the UI, the PR only returns a new field so the frontend can use it to filter the departments correctly, no?

@MartinSchoeler MartinSchoeler dismissed their stale review December 23, 2024 14:20

Fair enough, dismissing this review

@tapiarafael tapiarafael added this to the 7.3.0 milestone Dec 23, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA skipped labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants