Skip to content

Commit

Permalink
chore: remove redundant code in roxy and refine ci with paths fil…
Browse files Browse the repository at this point in the history
…ter (#8)

* refactor: remove redundant code and inappropriate name in roxy

* ci: use path filter to avoid unneccessary run of workflow
  • Loading branch information
J0HN50N133 authored Apr 15, 2024
1 parent dd7e909 commit 6a4f863
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 43 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ on:
branches: [ "*" ]
pull_request:
branches: [ "main" ]
paths:
# Run the workflow on every push to the main branch
- 'src/**'
- 'Cargo.toml'
- '.github/workflows/**'

env:
CARGO_TERM_COLOR: always
Expand Down
1 change: 0 additions & 1 deletion src/roxy/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,3 @@ pub mod datatypes;
pub mod error;
pub mod metadata;
pub mod storage;
pub mod write_batch;
8 changes: 4 additions & 4 deletions src/roxy/src/storage.rs
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,9 @@ pub struct StorageConfig {
#[serde(default)]
secondary_path: String,
#[serde(default)]
_open_mode: OpenMode,
open_mode: OpenMode,
#[serde(default)]
_backup_path: Option<String>,
backup_path: Option<String>,
rocksdb: RocksDBConfig,
}

Expand Down Expand Up @@ -284,8 +284,8 @@ pub fn setup_test_storage_for_ut() -> Storage {
let storage_config = StorageConfig {
dbpath,
secondary_path,
_open_mode: OpenMode::Default,
_backup_path: None,
open_mode: OpenMode::Default,
backup_path: None,
rocksdb: RocksDBConfig { block_size: 4096 },
};
let mut storage = Storage::try_new(storage_config).unwrap();
Expand Down
38 changes: 0 additions & 38 deletions src/roxy/src/write_batch.rs

This file was deleted.

0 comments on commit 6a4f863

Please sign in to comment.