-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sha1: Add extra .S for AArch64 on macOS (Fixing building on M1 Macs) #38
Conversation
I'm on vacation and away from my M1, so I'm unable to confirm this works correctly at this time. I'd prefer to wait until I can do that (or another projector contributor can) before merging this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not (and prefer not to) own any Apple devices, so I can't test this PR. But at the first glance it looks good.
I’ll be able to test it in a few days |
Is there any reason why |
I can confirm it builds. I would suggest adopting @Absolucy's suggestion to use |
Quite the nice solution, thanks for the Input! I added a commit which is also renaming the files (+ fixing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
@newpavlov any objections to merging this?
@tarcieri |
Okay, |
I applied the same fix as in #35 to the
sha1
version with@PAGE
for addressing and@PAGEOFF
for loading.It might not be an ideal solution, but it works for me and fixes #28 on my machine.