-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sha2): use latest sha2-asm and enable M1 #261
Conversation
5657fa4
to
32155c0
Compare
sha2/src/sha256/aarch64.rs
Outdated
#[cfg(target_os = "macos")] | ||
#[inline(always)] | ||
pub fn sha2_supported() -> bool { | ||
// TODO: Verify this is true for all available chips. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is. See the discussion here:
RustCrypto/utils#378 (comment)
Perhaps leave a TODO to use the cpufeatures
crate for this detection, once ARM support lands?
Confirm the tests pass on my M1 Mac Mini:
Edit: looks like they aren't passing on macOS/x86-64 in CI, though |
Benchmarks on Mac Mini M1: Soft
ASM
|
Co-authored-by: Tony Arcieri <[email protected]>
Depends on RustCrypto/asm-hashes#35
Benchmarks on Mac Mini M1:
Soft
ASM