JH #74
Closed
JH #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes unsound assumption about buffer alignment.
Disabled by default (not beneficial in tests on a Haswell VM)
|
I went ahead and made it Rust 1.21-compatible, with simd an opt-in feature |
|
The build failures are due to block-buffer and hex-literal, but I'm not sure why |
|
This PR is getting out of sync. The crate can be found here: https://github.com/cryptocorrosion/cryptocorrosion/tree/master/hashes/jh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import of the jh-x86_64 crate. Portable implementation plus compile-time-selected coresimd optimizations for sse2, ssse3, and avx2. This is, as far as I'm aware, the fastest implementation of JH due to the ssse3 optimizations, which improve performance to about 105.5% of the NIST submission's SSE2-bitsliced implementation on my machine.
Because this crate uses coresimd, merge will either need to wait until this project's minimum supported Rust version is increased, or I could feature-gate the optimizations. The portable fallback runs at a little under half the speed, and is about 10% faster than the "optimized 64-bit" implementation from the NIST package on my Nehalem box.
cf. #1