Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a zeroize trait for blockbuffers so that blake2 can have zeroize too (not zeroizeondrop- just zeroize) #832

Closed
wants to merge 2 commits into from

Conversation

laudiacay
Copy link

No description provided.

@laudiacay
Copy link
Author

oof. what should i do about this namespaced feature/nightly thing? @tarcieri

@laudiacay
Copy link
Author

RustCrypto/hashes#87 (comment)

the blockbuffer doesn't expose the underlying genericarray, or even allow you to have a mutable slice to hook zeroize up to. there are some weird setter methods but i am concerned that might get optimized out by the compiler.

i could alternatively add a method to pull a mutable slice out of mutable blockbuffers, or expose a genericarray, let me know which one is preferable to this.

Comment on lines 22 to 23
[features]
zeroize = ["dep:zeroize"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you just remove the entire [features] section I'd think it would be fine.

Namespaced features aren't MSRV-compatible, as they require Rust 1.60. The MSRV being tested in CI is 1.56 (although it doesn't seem to be correct in the README.md)

@newpavlov
Copy link
Member

Closing in favor of #963

@newpavlov newpavlov closed this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants