Provider secret special chars #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarlenKoch
requested a deployment
to
pr-e2e-approval
GitHub Actions
Waiting
MarlenKoch
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
MarlenKoch
requested a deployment
to
pr-e2e-approval
GitHub Actions
Waiting
sdischer-sap
requested a deployment
to
pr-e2e-approval
GitHub Actions
Waiting
sdischer-sap
requested changes
Dec 12, 2024
1 task
MarlenKoch
temporarily deployed
to
pr-e2e-approval
GitHub Actions
Inactive
sdischer-sap
temporarily deployed
to
pr-e2e-approval
GitHub Actions
Inactive
MarlenKoch
temporarily deployed
to
pr-e2e-approval
GitHub Actions
Inactive
maximiliantech
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When the provider secret contains a special char (like "), the error message is the following:
cannot create new Service: failed to get BTP accounts service client.: invalid character '9' after object key:value pairhttps://github.com/SAP/crossplane-provider-btp/blob/main/btp/cisclient.go#L236-L254
Solution:
This PR introduces a special error message in case the user credentials json can't be parsed.
Since there are two different secrets, one of which already had a more specific error message, I added the new error message to the user credentials (and not the cis-provider-secret).