better error message for invalid Service Manager credentials (#376)

SAP · Dec 17, 2023 · e420ff1 · e420ff1
1 parent 1e4f302
commit e420ff1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/Dockerfile b/Dockerfile
@@ -1,5 +1,5 @@
 # Build the manager binary
-FROM --platform=$BUILDPLATFORM golang:1.21.4-alpine as builder
+FROM --platform=$BUILDPLATFORM golang:1.21.5-alpine as builder
 
 WORKDIR /workspace
 # Copy the Go Modules manifests

diff --git a/controllers/base_controller.go b/controllers/base_controller.go
@@ -108,6 +108,12 @@ func (r *BaseReconciler) getSMClient(ctx context.Context, object api.SAPBTPResou
 		}
 	}
 
+	if len(cfg.ClientID) == 0 ||
+		len(cfg.ClientSecret) == 0 ||
+		len(cfg.URL) == 0 ||
+		len(cfg.TokenURL) == 0 {
+		return nil, fmt.Errorf("invalid Service-Manager credentials, contact your cluster administrator")
+	}
 	cl, err := sm.NewClient(ctx, cfg, nil)
 	return cl, err
 }