[WIP] Add option for adding annotations #482
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Prerequisites
#481
Motivation
I am using the btp-operator in a setup where it (among other microservices) is deployed via ArgoCD.
The parameters I use in the secret are imported from Hashicorp Vault via the ArgoCD Vault Plugin. Its' functionality relies on a certain annotation of the secret template and the current version of the secret doesn't provide the option to add this annotation.
Approach
With few simple changes of the secret template and the values file we can add the option for custom annotations.
Pull Request status
Third-party code
N/A