Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weekly Perlmutter Test #146

Merged
merged 132 commits into from
Nov 13, 2024
Merged

Weekly Perlmutter Test #146

merged 132 commits into from
Nov 13, 2024

Conversation

Angelyr
Copy link
Contributor

@Angelyr Angelyr commented Nov 12, 2024

  • Fixed tests failing on perlmutter
  • Added weekly perlmutter testing

@Angelyr Angelyr requested a review from jacobmerson November 12, 2024 16:17
cwsmith
cwsmith reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

@cwsmith cwsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I think it would help to rename the workflows/cmake-test.yml file to workflows/build_on_github_hosted_runner.yml or something like that.

@Angelyr Angelyr merged commit 9394b27 into develop Nov 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwsmith cwsmith cwsmith left review comments

@jacobmerson jacobmerson jacobmerson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Angelyr @cwsmith @jacobmerson