Fix API changes in SFML 3

SFML · May 31, 2024 · 44380e7 · 44380e7
1 parent 36a6e7c
commit 44380e7
Show file tree

Hide file tree

Showing 11 changed files with 97 additions and 166 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -46,7 +46,7 @@ jobs:
       uses: actions/checkout@v4
       with:
         repository: SFML/SFML
-        ref: c89c32d7baa15927a39a161a4ead867c11d5ea21
+        ref: b583eaf1606e54e5f443b094b3b2a6e3af72a5a4
         path: SFML
 
     - name: Configure SFML CMake

diff --git a/src/SFML/Audio/SoundBuffer.cpp b/src/SFML/Audio/SoundBuffer.cpp
@@ -34,30 +34,22 @@
 ////////////////////////////////////////////////////////////
 sfSoundBuffer* sfSoundBuffer_createFromFile(const char* filename)
 {
-    sfSoundBuffer* buffer = new sfSoundBuffer;
+    auto soundBuffer = sf::SoundBuffer::loadFromFile(filename);
+    if (!soundBuffer)
+        return nullptr;
 
-    if (!buffer->This.loadFromFile(filename))
-    {
-        delete buffer;
-        buffer = nullptr;
-    }
-
-    return buffer;
+    return new sfSoundBuffer{std::move(*soundBuffer)};
 }
 
 
 ////////////////////////////////////////////////////////////
 sfSoundBuffer* sfSoundBuffer_createFromMemory(const void* data, size_t sizeInBytes)
 {
-    sfSoundBuffer* buffer = new sfSoundBuffer;
-
-    if (!buffer->This.loadFromMemory(data, sizeInBytes))
-    {
-        delete buffer;
-        buffer = nullptr;
-    }
+    auto soundBuffer = sf::SoundBuffer::loadFromMemory(data, sizeInBytes);
+    if (!soundBuffer)
+        return nullptr;
 
-    return buffer;
+    return new sfSoundBuffer{std::move(*soundBuffer)};
 }
 
 
@@ -67,15 +59,12 @@ sfSoundBuffer* sfSoundBuffer_createFromStream(sfInputStream* stream)
 {
     CSFML_CHECK_RETURN(stream, nullptr);
 
-    sfSoundBuffer* buffer = new sfSoundBuffer;
     CallbackStream sfmlStream(stream);
-    if (!buffer->This.loadFromStream(sfmlStream))
-    {
-        delete buffer;
-        buffer = nullptr;
-    }
+    auto soundBuffer = sf::SoundBuffer::loadFromStream(sfmlStream);
+    if (!soundBuffer)
+        return nullptr;
 
-    return buffer;
+    return new sfSoundBuffer{std::move(*soundBuffer)};
 }
 
 
@@ -87,18 +76,15 @@ sfSoundBuffer* sfSoundBuffer_createFromSamples(const int16_t*    samples,
                                                sfSoundChannel*   channelMapData,
                                                size_t            channelMapSize)
 {
-    sfSoundBuffer* buffer = new sfSoundBuffer;
-
     std::vector<sf::SoundChannel> channelMap(channelMapSize);
     for (std::size_t i = 0; i < channelMap.size(); ++i)
         channelMap[i] = static_cast<sf::SoundChannel>(channelMapData[i]);
-    if (!buffer->This.loadFromSamples(samples, sampleCount, channelCount, sampleRate, channelMap))
-    {
-        delete buffer;
-        buffer = nullptr;
-    }
 
-    return buffer;
+    auto soundBuffer = sf::SoundBuffer::loadFromSamples(samples, sampleCount, channelCount, sampleRate, channelMap);
+    if (!soundBuffer)
+        return nullptr;
+
+    return new sfSoundBuffer{std::move(*soundBuffer)};
 }
 
 

diff --git a/src/SFML/Audio/SoundBufferRecorder.cpp b/src/SFML/Audio/SoundBufferRecorder.cpp
@@ -70,9 +70,9 @@ const sfSoundBuffer* sfSoundBufferRecorder_getBuffer(const sfSoundBufferRecorder
 {
     CSFML_CHECK_RETURN(soundBufferRecorder, nullptr);
 
-    soundBufferRecorder->SoundBuffer.This = soundBufferRecorder->This.getBuffer();
+    soundBufferRecorder->SoundBuffer = sfSoundBuffer{soundBufferRecorder->This.getBuffer()};
 
-    return &soundBufferRecorder->SoundBuffer;
+    return &*soundBufferRecorder->SoundBuffer;
 }
 
 ////////////////////////////////////////////////////////////

diff --git a/src/SFML/Audio/SoundBufferRecorderStruct.h b/src/SFML/Audio/SoundBufferRecorderStruct.h
@@ -31,15 +31,17 @@
 #include <SFML/Audio/SoundBufferRecorder.hpp>
 #include <SFML/Audio/SoundBufferStruct.h>
 
+#include <optional>
+
 
 ////////////////////////////////////////////////////////////
 // Internal structure of sfSoundBufferRecorder
 ////////////////////////////////////////////////////////////
 struct sfSoundBufferRecorder
 {
-    sf::SoundBufferRecorder This;
-    mutable sfSoundBuffer   SoundBuffer;
-    std::string             DeviceName;
+    sf::SoundBufferRecorder              This;
+    mutable std::optional<sfSoundBuffer> SoundBuffer;
+    std::string                          DeviceName;
 };
 
 

diff --git a/src/SFML/Graphics/Font.cpp b/src/SFML/Graphics/Font.cpp
@@ -34,28 +34,22 @@
 ////////////////////////////////////////////////////////////
 sfFont* sfFont_createFromFile(const char* filename)
 {
-    sfFont* font = new sfFont;
-    if (!font->This.loadFromFile(filename))
-    {
-        delete font;
-        font = nullptr;
-    }
+    auto font = sf::Font::loadFromFile(filename);
+    if (!font)
+        return nullptr;
 
-    return font;
+    return new sfFont{std::move(*font), {}, {}};
 }
 
 
 ////////////////////////////////////////////////////////////
 sfFont* sfFont_createFromMemory(const void* data, size_t sizeInBytes)
 {
-    sfFont* font = new sfFont;
-    if (!font->This.loadFromMemory(data, sizeInBytes))
-    {
-        delete font;
-        font = nullptr;
-    }
+    auto font = sf::Font::loadFromMemory(data, sizeInBytes);
+    if (!font)
+        return nullptr;
 
-    return font;
+    return new sfFont{std::move(*font), {}, {}};
 }
 
 
@@ -64,15 +58,12 @@ sfFont* sfFont_createFromStream(sfInputStream* stream)
 {
     CSFML_CHECK_RETURN(stream, nullptr);
 
-    sfFont* font = new sfFont;
-    font->Stream = CallbackStream(stream);
-    if (!font->This.loadFromStream(font->Stream))
-    {
-        delete font;
-        font = nullptr;
-    }
+    auto sfmlStream = std::make_shared<CallbackStream>(stream);
+    auto font = sf::Font::loadFromStream(*sfmlStream);
+    if (!font)
+        return nullptr;
 
-    return font;
+    return new sfFont{std::move(*font), {}, std::move(sfmlStream)};
 }
 
 

diff --git a/src/SFML/Graphics/FontStruct.h b/src/SFML/Graphics/FontStruct.h
@@ -32,6 +32,7 @@
 #include <SFML/Graphics/TextureStruct.h>
 #include <SFML/CallbackStream.h>
 #include <map>
+#include <memory>
 
 
 ////////////////////////////////////////////////////////////
@@ -41,7 +42,7 @@ struct sfFont
 {
     sf::Font This;
     std::map<unsigned int, sfTexture> Textures;
-    CallbackStream Stream;
+    std::shared_ptr<CallbackStream> Stream;
 };
 
 

diff --git a/src/SFML/Graphics/Image.cpp b/src/SFML/Graphics/Image.cpp
@@ -35,60 +35,43 @@
 ////////////////////////////////////////////////////////////
 sfImage* sfImage_create(unsigned int width, unsigned int height)
 {
-    sfImage* image = new sfImage;
-    image->This.create({ width, height });
-
-    return image;
+    return new sfImage{sf::Image({width, height})};
 }
 
 
 ////////////////////////////////////////////////////////////
 sfImage* sfImage_createFromColor(unsigned int width, unsigned int height, sfColor color)
 {
-    sfImage* image = new sfImage;
-    image->This.create({ width, height }, sf::Color(color.r, color.g, color.b, color.a));
-
-    return image;
+    return new sfImage{sf::Image({ width, height }, sf::Color(color.r, color.g, color.b, color.a))};
 }
 
 
 ////////////////////////////////////////////////////////////
 sfImage* sfImage_createFromPixels(unsigned int width, unsigned int height, const uint8_t* data)
 {
-    sfImage* image = new sfImage;
-    image->This.create({ width, height }, data);
-
-    return image;
+    return new sfImage{sf::Image({ width, height }, data)};
 }
 
 
 ////////////////////////////////////////////////////////////
 sfImage* sfImage_createFromFile(const char* filename)
 {
-    sfImage* image = new sfImage;
-
-    if (!image->This.loadFromFile(filename))
-    {
-        delete image;
-        image = nullptr;
-    }
+    auto image = sf::Image::loadFromFile(filename);
+    if (!image)
+        return nullptr;
 
-    return image;
+    return new sfImage{std::move(*image)};
 }
 
 
 ////////////////////////////////////////////////////////////
 sfImage* sfImage_createFromMemory(const void* data, size_t sizeInBytes)
 {
-    sfImage* image = new sfImage;
+    auto image = sf::Image::loadFromMemory(data, sizeInBytes);
+    if (!image)
+        return nullptr;
 
-    if (!image->This.loadFromMemory(data, sizeInBytes))
-    {
-        delete image;
-        image = nullptr;
-    }
-
-    return image;
+    return new sfImage{std::move(*image)};
 }
 
 
@@ -97,16 +80,12 @@ sfImage* sfImage_createFromStream(sfInputStream* stream)
 {
     CSFML_CHECK_RETURN(stream, nullptr);
 
-    sfImage* image = new sfImage;
-
     CallbackStream sfmlStream(stream);
-    if (!image->This.loadFromStream(sfmlStream))
-    {
-        delete image;
-        image = nullptr;
-    }
+    auto image = sf::Image::loadFromStream(sfmlStream);
+    if (!image)
+        return nullptr;
 
-    return image;
+    return new sfImage{std::move(*image)};
 }
 
 

diff --git a/src/SFML/Graphics/RenderTexture.cpp b/src/SFML/Graphics/RenderTexture.cpp
@@ -51,19 +51,14 @@ sfRenderTexture* sfRenderTexture_create(unsigned int width, unsigned int height,
     }
 
     // Create the render texture
-    sfRenderTexture* renderTexture = new sfRenderTexture;
-
-    if (!renderTexture->This.create({ width, height }, params))
-    {
-        delete renderTexture;
+    auto renderTexture = sf::RenderTexture::create({ width, height }, params);
+    if (!renderTexture)
         return nullptr;
-    }
-
-    renderTexture->Target = new sfTexture(const_cast<sf::Texture*>(&renderTexture->This.getTexture()));
-    renderTexture->DefaultView.This = renderTexture->This.getDefaultView();
-    renderTexture->CurrentView.This = renderTexture->This.getView();
 
-    return renderTexture;
+    return new sfRenderTexture{std::move(*renderTexture),
+                               new sfTexture(const_cast<sf::Texture*>(&renderTexture->getTexture())),
+                               {renderTexture->getDefaultView()},
+                               {renderTexture->getView()}};
 }