cast to larger type before doing arithmetic to avoid signed integer o… #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZXShady
force-pushed
the
avoid_signed_overflow_ub
branch
from
446ff82 to
8239d45
Compare
ChrisThrasher
requested changes
Sep 29, 2024
ZXShady
force-pushed
the
avoid_signed_overflow_ub
branch
from
8239d45 to
03168dd
Compare
ChrisThrasher
approved these changes
Sep 29, 2024
…verflow https://godbolt.org/z/soTad4zEq this godbolt links shows that it is UB to multiply then cast if the amount is large enough
ChrisThrasher
force-pushed
the
avoid_signed_overflow_ub
branch
from
03168dd to
182edce
Compare
ChrisThrasher
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…verflow
https://godbolt.org/z/soTad4zEq
this godbolt links shows that it is UB to multiply then cast if the amount is large enough