Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid flaky expectations capturing values during a hardcoded time interval #1099

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

defagos
Copy link
Member

@defagos defagos commented Dec 12, 2024

Description

This PR avoids expectations capturing values during a hardcoded time interval, which can be much flakier on a CI agent.

Changes made

  • Replace such expectations with their at least counterpart.
  • Tweak other legitimate expectation intervals for consistency (500 ms).

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@defagos defagos linked an issue Dec 12, 2024 that may be closed by this pull request
1 task
@defagos defagos added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit a1749bf Dec 12, 2024
7 checks passed
@defagos defagos deleted the 1097-avoid-expectations-for-periods-of-time branch December 12, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Avoid expectations for periods of time
2 participants