-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add param forceSAM=true
when targeting sam endpoint
#56
Conversation
4f85d92
to
e306172
Compare
e306172
to
6be9b60
Compare
If I understand well if a call is possible threw SAM, the parameters forceSAM=true have to be present? It is a bit wired. this query param have no effect if the call hasn't SAM yet? |
Could this interceptor added by the integrators later? But I think not possible. In the future, the OkHttpClient creation should be the responsability of the library user, not the library itself. |
After a discussion with Pierre-Yves, he told me the parameters |
This PR bumps Data Provider version to 0.11.0. ## What's Changed * Update GitHub Actions workflow by @MGaetan89 in #44 * Update to Gradle 8.10 and fix deprecation warnings by @MGaetan89 in #45 * Fix warnings in Java/Kotlin code by @MGaetan89 in #46 * Update dependencies by @MGaetan89 in #47 * Update demo app to display request response by @MGaetan89 in #48 * Migrate Java files to Kotlin by @MGaetan89 in #49 * Update dependencies by @MGaetan89 in #53 * Bump androidx.lifecycle:lifecycle-runtime from 2.8.6 to 2.8.7 in the androidx group by @dependabot in #54 * Bump org.robolectric:robolectric from 4.13 to 4.14 by @dependabot in #58 * Bump android-gradle-plugin from 8.7.1 to 8.7.2 by @dependabot in #55 * Bump androidx.paging:paging-common from 3.3.2 to 3.3.4 in the androidx group by @dependabot in #57 * Update nexus repository url by @StaehliJ in #59 * Bump org.robolectric:robolectric from 4.14 to 4.14.1 by @dependabot in #60 * Add param `forceSAM=true` when targeting sam endpoint by @Loic-Dumas in #56 * Bump kotlin from 2.0.21 to 2.1.0 by @dependabot in #61 * Bump android-gradle-plugin from 8.7.2 to 8.7.3 by @dependabot in #62
Description
All sam call need to have the param
forceSAM=true
to ensure call are retrieved from SAM and not proxied through IL.Changes made:
HostInterceptor
to add paramforceSAM=true
to all calls made to sam end points (prod, stage, test).